Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom settings for calibration and visualization options #341

Merged
merged 14 commits into from
Mar 20, 2023

Conversation

dariosortino
Copy link
Collaborator

As per the title, with @S-Dafarra we included the possibility to define window's Height and Width from the configuration file of the Human State Visualizer. Also, with @lrapetti and @mebbaid we define a new parameter called CalibrationConfig that allows setting custom angles for calibration purposes.

Copy link
Member

@lrapetti lrapetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dariosortino for the new features.

I added some comments. Remember also to update the Changelog file with a description of the new features!

devices/HumanStateProvider/HumanStateProvider.cpp Outdated Show resolved Hide resolved
devices/HumanStateProvider/HumanStateProvider.cpp Outdated Show resolved Hide resolved
devices/HumanStateProvider/HumanStateProvider.cpp Outdated Show resolved Hide resolved
devices/HumanStateProvider/HumanStateProvider.cpp Outdated Show resolved Hide resolved
devices/HumanStateProvider/HumanStateProvider.cpp Outdated Show resolved Hide resolved
modules/HumanStateVisualizer/src/main.cpp Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Riccardo Grieco <[email protected]>
Copy link
Contributor

@RiccardoGrieco RiccardoGrieco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dariosortino for addressing all the points, I will proceed merging it once all the conversation are resolved.

Copy link
Member

@lrapetti lrapetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dariosortino! Thanks

@lrapetti
Copy link
Member

This new feature might be interesting also for @claudia-lat since in the past we collected some dataset that cannot be calibrated in t-pose, but might be calibrated in n-pose

@RiccardoGrieco
Copy link
Contributor

Thank you everyone, merging.

@RiccardoGrieco RiccardoGrieco merged commit 58ad913 into master Mar 20, 2023
@RiccardoGrieco RiccardoGrieco deleted the VizSettings branch March 20, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants